Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 'config' to be supplied to all user-side functions except make() and drake_config() #170

Closed
wlandau-lilly opened this issue Nov 25, 2017 · 1 comment

Comments

@wlandau-lilly
Copy link
Collaborator

This will simplify and fortify the code base. Functions like vis_drake_graph() take a bunch of arguments and then construct a drake_config() list if one is not already supplied. This generates a lot of confusion, repeat code, and room for error. Only make() and drake_config() should take arguments like parallelism and jobs and verbose in the usual way. The others should be required to get them from a drake_config() list.

wlandau-lilly added a commit that referenced this issue Nov 25, 2017
Now it's just a matter of cleaning up and finishing #170.
wlandau-lilly added a commit that referenced this issue Nov 25, 2017
Need to update tests and vignettes.
@wlandau-lilly
Copy link
Collaborator Author

wlandau-lilly commented Nov 25, 2017

Fixed. Affected functions:

  • outdated()
  • missed()
  • rate_limiting_times()
  • predict_runtime()
  • vis_drake_graph()
  • dataframes_graph()
    The changes were more straightforward than I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant