Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an S3 "drake_plan" class #494

Merged
merged 7 commits into from
Aug 5, 2018
Merged

Use an S3 "drake_plan" class #494

merged 7 commits into from
Aug 5, 2018

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Aug 5, 2018

Summary

The new S3 "drake_plan" class will enable us to define a special print() method for workflow plan data frames. Work on this will continue in R/drake_plan_class.R and R/drake_plan_print.R.

Related GitHub issues and pull requests

Checklist

  • I have read drake's code of conduct, and I agree to follow its rules.
  • I have read the guidelines for contributing.
  • I have listed any substantial changes in the development news.
  • I have added testthat unit tests to tests/testthat to confirm that any new features or functionality work correctly.
  • I have tested this pull request locally with devtools::check()
  • This pull request is ready for review.
  • I think this pull request is ready to merge.

@wlandau wlandau self-assigned this Aug 5, 2018
@wlandau
Copy link
Member Author

wlandau commented Aug 5, 2018

We still have difficulties getting the class to stick: https://stackoverflow.com/questions/51693365/extending-tibble-getting-the-new-s3-class-to-stick. Not sure how to resolve.

@codecov-io
Copy link

codecov-io commented Aug 5, 2018

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #494   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          68     70    +2     
  Lines        5979   5986    +7     
=====================================
+ Hits         5979   5986    +7
Impacted Files Coverage Δ
R/mtcars_example.R 100% <100%> (ø) ⬆️
R/drake_plan_class.R 100% <100%> (ø)
R/drake_plan_print.R 100% <100%> (ø)
R/generate_plans.R 100% <100%> (ø) ⬆️
R/sanitize.R 100% <100%> (ø) ⬆️
R/drake_plan.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff4812...2c2d5b0. Read the comment docs.

@wlandau wlandau merged commit 0406942 into master Aug 5, 2018
@wlandau wlandau deleted the drake_plan_class branch August 5, 2018 12:27
@wlandau wlandau mentioned this pull request Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants