Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manual base 64 encoding, file paths only. #633

Merged
merged 36 commits into from
Dec 21, 2018
Merged

Use manual base 64 encoding, file paths only. #633

merged 36 commits into from
Dec 21, 2018

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Dec 20, 2018

Summary

Fixes #630 and #572. Also related: #631. Significant speed improvement while preserving back compatibility with old projects. See #630 for discussion and benchmarks.

Related GitHub issues and pull requests

Checklist

  • I have read drake's code of conduct, and I agree to follow its rules.
  • I have listed any substantial changes in the development news.
  • I have added testthat unit tests to tests/testthat to confirm that any new features or functionality work correctly.
  • I have tested this pull request locally with devtools::check()
  • This pull request is ready for review.
  • I think this pull request is ready to merge.

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #633 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #633   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          82     82           
  Lines        6951   6968   +17     
=====================================
+ Hits         6951   6968   +17
Impacted Files Coverage Δ
R/subspace.R 100% <ø> (ø) ⬆️
R/code_analysis_utils.R 100% <ø> (ø) ⬆️
R/handlers.R 100% <ø> (ø) ⬆️
R/strings.R 100% <100%> (ø) ⬆️
R/cache_ui.R 100% <100%> (ø) ⬆️
R/build_times.R 100% <100%> (ø) ⬆️
R/check.R 100% <100%> (ø) ⬆️
R/diagnose.R 100% <100%> (ø) ⬆️
R/outdated.R 100% <100%> (ø) ⬆️
R/encoding.R 100% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d15bb1...e3dabc1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants