-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A much friendlier API for creating large plans #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could have really used this for wildcards
Needs to compute its own levels
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 71 72 +1
Lines 5512 5588 +76
=====================================
+ Hits 5512 5588 +76
Continue to review full report at Codecov.
|
This was referenced Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines concepts from the proposed DSL (#233) and
target()
. Both were amazingly helpful ideas from @krlmlr. Also cc @AlexAxthelm, @dapperjapper, @tiernanmartin, @tmastny, @lorenzwalthert, and @idavydov. Hopefully we can work this into the delayed expansion idea from #233.The implementation is still experimental, but it is noninvasive. It is lightweight, and because it relies on a custom
"transform
" column in the plan, it does not interfere with any other functionality (internals or API).Created on 2019-01-14 by the reprex package (v0.2.1)
Related GitHub issues and pull requests
Checklist
drake
's code of conduct, and I agree to follow its rules.testthat
unit tests totests/testthat
to confirm that any new features or functionality work correctly.devtools::check()