Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npi_flatten: Investigate and test edge cases #73

Closed
frankfarach opened this issue Apr 9, 2022 · 0 comments
Closed

npi_flatten: Investigate and test edge cases #73

frankfarach opened this issue Apr 9, 2022 · 0 comments
Assignees
@frankfarach
Labels
staged Issue is staged for merging
Milestone
rOpenSci Review

Comments

@frankfarach
Copy link
Collaborator

See ropensci/software-review#505 (comment):

Does npi_flatten() always return a sensible result? It seems like it merges together a lot of different pieces of information from different list columns but does it always make sense to cross-tabulate every single one? I don't have an idea of where it might go wrong, but always wonder when merging tibbles with different numbers of rows.
@frankfarach frankfarach added this to the rOpenSci Review milestone Apr 9, 2022
@frankfarach frankfarach self-assigned this Apr 9, 2022
@frankfarach frankfarach changed the title Investigate and test npi_flatten edge cases npi_flatten: Investigate and test edge cases Apr 9, 2022
frankfarach added a commit that referenced this issue Nov 2, 2022
@frankfarach
Cover npi_flatten() with unit tests for #73
3653899
frankfarach added a commit that referenced this issue Nov 2, 2022
@frankfarach
Closes #73. Add guidance on npi_flatten() to README.
0565f4d
@frankfarach frankfarach added the staged Issue is staged for merging label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankfarach frankfarach

Labels
staged Issue is staged for merging
Projects
None yet
Milestone
rOpenSci Review
Development

No branches or pull requests
1 participant
@frankfarach