Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewers #30

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Add reviewers #30

merged 4 commits into from
Jun 21, 2024

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Jun 21, 2024

@jmaspons
Copy link
Collaborator Author

@jonthegeek, @ccamara can you confirm that's find and propose change if needed (e.g., orcid or whatever)?

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (9b3970a) to head (5d04ff5).
Report is 4 commits behind head on main.

Current head 5d04ff5 differs from pull request most recent head cc514a5

Please upload reports for the commit cc514a5 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files          27       27           
  Lines        2231     2231           
=======================================
  Hits         2076     2076           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added my ORCID. Merge that in and then it looks good to me!

DESCRIPTION Outdated Show resolved Hide resolved
jmaspons and others added 3 commits June 21, 2024 12:53
Co-authored-by: Jon Harmon <jonthegeek@gmail.com>
@jmaspons
Copy link
Collaborator Author

Merging now. Feel free to ask for changes, @ccamara

@jmaspons jmaspons merged commit bced458 into main Jun 21, 2024
7 checks passed
@jmaspons jmaspons deleted the rev branch June 21, 2024 19:52
@ccamara
Copy link
Contributor

ccamara commented Jun 25, 2024

Thanks for this, @jmaspons , just submitted a PR to include my orcid: #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants