Changes for readr 2.0.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In readr 2.0.0 blank lines are not implicitly skipped. It seems the GloBI service returns data with a trailing blank line, so we need to drop these rows with all NA values. In addition testthat supports a helper file which is automatically sourced before running your tests or when using `devtools::load_all()`. I moved the test utils functions into this file. I also suppressed the parsing warnings as well as the messages, as that clears up some spurious output when running the tests.
|
@jimhester thanks Jim! Good luck with the readr 2.0.0 release, sounds like an exciting release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In readr 2.0.0 blank lines are not implicitly skipped. It seems the
GloBI service returns data with a trailing blank line, so we need to
drop these rows with all NA values.
In addition testthat supports a helper file which is automatically
sourced before running your tests or when using
devtools::load_all().I moved the test utils functions into this file.
I also suppressed the parsing warnings as well as the messages, as that
clears up some spurious output when running the tests.
We plan to submit readr 2.0.0 in 2-4 weeks from now. You will need to submit these changes to CRAN before then to avoid test failures on CRAN.