Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description suggests update 102 #115

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

jooolia
Copy link
Member

@jooolia jooolia commented Jul 14, 2020

This fixes a missing dependency seen when running devtools::check_win_devel() as part of the checks in issue #102. This adds {markdown} to suggests in the description (as suggested here: https://win-builder.r-project.org/iUiM5i0dzCRa/00check.log

@jooolia jooolia requested a review from sinarueeger July 14, 2020 15:40
@jooolia jooolia changed the base branch from master to dev July 14, 2020 15:41
@sinarueeger
Copy link
Contributor

annotations() unittest seems to fail - very strange. I can look into that tomorrow.

@jooolia
Copy link
Member Author

jooolia commented Jul 14, 2020

Hi @sinarueeger , It is a bit bizarre. I cannot reproduce it on my windows machine, but will also check tomorrow morning on my Mac.

@jooolia jooolia closed this Jul 15, 2020
@jooolia jooolia reopened this Jul 15, 2020
@jooolia
Copy link
Member Author

jooolia commented Jul 15, 2020

Hi @sinarueeger , I closed and re-opened to re-trigger the build as I could not reproduce the failing test on my mac (sesssionInfo() included below.

sessionInfo()
#> R version 3.6.2 (2019-12-12)
#> Platform: x86_64-apple-darwin15.6.0 (64-bit)
#> Running under: macOS Mojave 10.14.6
#> 
#> Matrix products: default
#> BLAS:   /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRblas.0.dylib
#> LAPACK: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRlapack.dylib
#> 
#> locale:
#> [1] en_CA.UTF-8/en_CA.UTF-8/en_CA.UTF-8/C/en_CA.UTF-8/en_CA.UTF-8
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> loaded via a namespace (and not attached):
#>  [1] compiler_3.6.2  magrittr_1.5    tools_3.6.2     htmltools_0.5.0
#>  [5] yaml_2.2.1      stringi_1.4.6   rmarkdown_2.3   highr_0.8      
#>  [9] knitr_1.29      stringr_1.4.0   xfun_0.15       digest_0.6.25  
#> [13] rlang_0.4.6     evaluate_0.14

Created on 2020-07-15 by the reprex package (v0.3.0)

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #115 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #115   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files          13       13           
  Lines         318      318           
=======================================
  Hits          205      205           
  Misses        113      113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbfd74...8cdd463. Read the comment docs.

@jooolia
Copy link
Member Author

jooolia commented Jul 15, 2020

Ok now it passes @sinarueeger. :)

@sinarueeger
Copy link
Contributor

Thanks @jooolia !

Copy link
Contributor

@sinarueeger sinarueeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jooolia jooolia merged commit 6499281 into dev Jul 15, 2020
@jooolia jooolia deleted the description_suggests_update_102 branch July 15, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants