-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description suggests update 102 #115
Conversation
|
Hi @sinarueeger , It is a bit bizarre. I cannot reproduce it on my windows machine, but will also check tomorrow morning on my Mac. |
Hi @sinarueeger , I closed and re-opened to re-trigger the build as I could not reproduce the failing test on my mac ( sessionInfo()
#> R version 3.6.2 (2019-12-12)
#> Platform: x86_64-apple-darwin15.6.0 (64-bit)
#> Running under: macOS Mojave 10.14.6
#>
#> Matrix products: default
#> BLAS: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRblas.0.dylib
#> LAPACK: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRlapack.dylib
#>
#> locale:
#> [1] en_CA.UTF-8/en_CA.UTF-8/en_CA.UTF-8/C/en_CA.UTF-8/en_CA.UTF-8
#>
#> attached base packages:
#> [1] stats graphics grDevices utils datasets methods base
#>
#> loaded via a namespace (and not attached):
#> [1] compiler_3.6.2 magrittr_1.5 tools_3.6.2 htmltools_0.5.0
#> [5] yaml_2.2.1 stringi_1.4.6 rmarkdown_2.3 highr_0.8
#> [9] knitr_1.29 stringr_1.4.0 xfun_0.15 digest_0.6.25
#> [13] rlang_0.4.6 evaluate_0.14 Created on 2020-07-15 by the reprex package (v0.3.0) |
Codecov Report
@@ Coverage Diff @@
## dev #115 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 13 13
Lines 318 318
=======================================
Hits 205 205
Misses 113 113 Continue to review full report at Codecov.
|
Ok now it passes @sinarueeger. :) |
Thanks @jooolia ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes a missing dependency seen when running
devtools::check_win_devel()
as part of the checks in issue #102. This adds {markdown} to suggests in the description (as suggested here: https://win-builder.r-project.org/iUiM5i0dzCRa/00check.log