Develop to master

ropensci · Oct 28, 2019 · b4fbfd3 · b4fbfd3
2 parents 3419cd4 + fb68e6d
commit b4fbfd3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/R/skim_with.R b/R/skim_with.R
@@ -145,7 +145,8 @@ validate_assignment <- function(...) {
 
   defaults <- get_default_skimmers()
   existing <- proposed_names %in% names(defaults)
-  if (!all(existing)) {
+
+  if (!all(existing) & length(defaults) > 0 ) {
     collapsed <- paste(proposed_names[!existing], collapse = ", ")
     message(
       "Creating new skimming functions for the following classes: ",

diff --git a/README.Rmd b/README.Rmd
@@ -220,7 +220,7 @@ RMarkdown documents, it cannot in other circumstances. This includes:
 
 One workaround for showing these characters in Windows is to set the CTYPE part
 of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE",
-"Chinese"). The helper function `fix_windows_histograms()` does this for you.
+"Chinese")`. The helper function `fix_windows_histograms()` does this for you.
 
 And last but not least, we provide `skim_without_charts()` as a fallback.
 This makes it easy to still get summaries of your data, even if unicode issues

diff --git a/README.md b/README.md
@@ -641,10 +641,9 @@ includes:
 -   in the context of rendering to a pdf using an engine that does not
     support utf-8.
 
-One workaround for showing these characters in Windows is to set the
-CTYPE part of your locale to Chinese/Japanese/Korean with
-`Sys.setlocale("LC_CTYPE", "Chinese"). The helper function`fix\_windows\_histograms()\`
-does this for you.
+One workaround for showing these characters in Windows is to set the CTYPE part
+of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE",
+"Chinese")`. The helper function `fix_windows_histograms()` does this for you.
 
 And last but not least, we provide `skim_without_charts()` as a
 fallback. This makes it easy to still get summaries of your data, even