checks

R/utils_retry.R

@@ -28,7 +28,6 @@ retry_until_success <- function(
       start = start
     )
   }
-  out
 }
 
 retry_attempt_success <- function(fun, args, envir, verbose, classes_retry) {

tests/testthat/test-tar_resources.R

@@ -7,8 +7,8 @@ tar_test("populated resources", {
   skip_on_os("windows")
   skip_if_not_installed("paws.storage")
   out <- tar_resources(
-    aws = resources_aws_init(),
-    gcp = resources_gcp_init(),
+    aws = resources_aws_init(prefix = "x"),
+    gcp = resources_gcp_init(prefix = "x"),
     clustermq = resources_clustermq_init(
       template = list(a = 1, n_cores = 123)
     )
@@ -24,11 +24,14 @@ tar_test("default resource args", {
   skip_cran()
   skip_on_os("windows")
   skip_if_not_installed("paws.storage")
-  tar_option_set(
-    resources = tar_resources(
-      aws = tar_resources_aws(bucket = "abc"),
-      fst = tar_resources_fst(compress = 10L)
-    )
+  suppressWarnings(
+    tar_option_set(
+      resources = tar_resources(
+        aws = tar_resources_aws(bucket = "abc"),
+        fst = tar_resources_fst(compress = 10L)
+      )
+    ),
+    classes = "tar_condition_deprecate"
   )
   target <- tar_target(
     x,

tests/testthat/test-tar_resources_aws.R

@@ -2,7 +2,7 @@ tar_test("tar_resources_aws()", {
   skip_cran()
   skip_on_os("windows")
   skip_if_not_installed("paws.storage")
-  out <- tar_resources_aws(bucket = "bucket123")
+  out <- tar_resources_aws(bucket = "bucket123", prefix = "x")
   expect_equal(out$bucket, "bucket123")
   expect_null(out$region)
   expect_silent(resources_validate(out))
@@ -12,7 +12,11 @@ tar_test("tar_resources_aws() with region", {
   skip_cran()
   skip_on_os("windows")
   skip_if_not_installed("paws.storage")
-  out <- tar_resources_aws(bucket = "bucket123", region = "us-east-1")
+  out <- tar_resources_aws(
+    bucket = "bucket123",
+    region = "us-east-1",
+    prefix = "x"
+  )
   expect_equal(out$region, "us-east-1")
   expect_silent(resources_validate(out))
 })
@@ -21,7 +25,11 @@ tar_test("tar_resources_aws() with part_size", {
   skip_cran()
   skip_on_os("windows")
   skip_if_not_installed("paws.storage")
-  out <- tar_resources_aws(bucket = "bucket123", part_size = 1e8)
+  out <- tar_resources_aws(
+    bucket = "bucket123",
+    part_size = 1e8,
+    prefix = "x"
+  )
   expect_equal(out$part_size, 1e8)
   expect_silent(resources_validate(out))
 })
@@ -33,7 +41,8 @@ tar_test("tar_resources_aws() default bucket", {
   tar_option_set(
     resources = tar_resources(
       aws = tar_resources_aws(
-        bucket = "bucket123"
+        bucket = "bucket123",
+        prefix = "x"
       )
     )
   )
@@ -64,7 +73,8 @@ tar_test("tar_resources_aws() default part_size", {
   tar_option_set(
     resources = tar_resources(
       aws = tar_resources_aws(
-        part_size = 1e2
+        part_size = 1e2,
+        prefix = "x"
       )
     )
   )
@@ -79,7 +89,8 @@ tar_test("tar_resources_aws() default region", {
   tar_option_set(
     resources = tar_resources(
       aws = tar_resources_aws(
-        region = "the_moon"
+        region = "the_moon",
+        prefix = "x"
       )
     )
   )
@@ -94,7 +105,8 @@ tar_test("tar_resources_aws() default endpoint", {
   tar_option_set(
     resources = tar_resources(
       aws = tar_resources_aws(
-        endpoint = "google"
+        endpoint = "google",
+        prefix = "x"
       )
     )
   )
@@ -109,7 +121,8 @@ tar_test("tar_resources_aws() default SSECustomerKey", {
   tar_option_set(
     resources = tar_resources(
       aws = tar_resources_aws(
-        SSECustomerKey = "x"
+        SSECustomerKey = "x",
+        prefix = "x"
       )
     )
   )

tests/testthat/test-tar_resources_gcp.R

@@ -1,5 +1,5 @@
 tar_test("tar_resources_gcp()", {
-  out <- tar_resources_gcp(bucket = "bucket123")
+  out <- tar_resources_gcp(bucket = "bucket123", prefix = "x")
   expect_equal(out$bucket, "bucket123")
   expect_null(out$region)
   expect_silent(resources_validate(out))
@@ -15,7 +15,8 @@ tar_test("tar_resources_gcp() default bucket", {
   tar_option_set(
     resources = tar_resources(
       gcp = tar_resources_gcp(
-        bucket = "non_default"
+        bucket = "non_default",
+        prefix = "x"
       )
     )
   )
@@ -39,7 +40,8 @@ tar_test("tar_resources_gcp() default predefined_acl", {
   tar_option_set(
     resources = tar_resources(
       gcp = tar_resources_gcp(
-        predefined_acl = "non_default"
+        predefined_acl = "non_default",
+        prefix = "x"
       )
     )
   )
@@ -51,7 +53,8 @@ tar_test("tar_resources_gcp() default predefined_acl", {
   tar_option_set(
     resources = tar_resources(
       gcp = tar_resources_gcp(
-        verbose = TRUE
+        verbose = TRUE,
+        prefix = "x"
       )
     )
   )

tests/testthat/test-utils_assert.R

@@ -249,7 +249,7 @@ tar_test("tar_assert_resources()", {
     tar_assert_resources(list(aws = 1)),
     class = "tar_condition_deprecate"
   )
-  aws <- tar_resources_aws(bucket = "bucket")
+  aws <- tar_resources_aws(bucket = "bucket", prefix = "x")
   expect_silent(tar_assert_resources(tar_resources(aws = aws)))
 })
 

tests/testthat/test-utils_retry.R

@@ -82,6 +82,16 @@ tar_test("retry_until_true() max_tries", {
   expect_equal(envir$count, 5L)
 })
 
+tar_test("retry_until_success() success", {
+  skip_on_cran()
+  out <- retry_until_success(
+    fun = function() {
+      "done"
+    }
+  )
+  expect_equal(out, "done")
+})
+
 tar_test("retry_until_success() uncaught class", {
   skip_on_cran()
   tmp <- tempfile()