Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response to reviewers #5

Merged
merged 12 commits into from
Apr 29, 2022
Merged

Response to reviewers #5

merged 12 commits into from
Apr 29, 2022

Conversation

mikemahoney218
Copy link
Member

This PR will address all comments from the rOpenSci review process; it won't be merged for a bit yet, but I want CI to run against these commits.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had a few minor comments on the user guide, but overall looks a lot better!

vignettes/unifir-user-guide.Rmd Outdated Show resolved Hide resolved
vignettes/unifir-user-guide.Rmd Outdated Show resolved Hide resolved
vignettes/unifir-user-guide.Rmd Outdated Show resolved Hide resolved
@mikemahoney218 mikemahoney218 merged commit 70cc8e2 into main Apr 29, 2022
Copy link

github-actions bot commented Feb 2, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants