Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a custom testthat skipper? #191

Closed
maelle opened this issue Nov 16, 2020 · 4 comments · Fixed by #195
Closed

provide a custom testthat skipper? #191

maelle opened this issue Nov 16, 2020 · 4 comments · Fixed by #195
Milestone
v0.6

Comments

@maelle
Copy link
Member

maelle commented Nov 16, 2020

that'd be skip_if_vcr_off()
@sckott
Copy link
Collaborator

sckott commented Nov 16, 2020

the use case is if user has turned off vcr with env var and then want to make sure test won't run if vcr off?

@maelle
Copy link
Member Author

maelle commented Nov 16, 2020

Yes because they'd be tests with an edited cassette for instance

@sckott
Copy link
Collaborator

sckott commented Nov 16, 2020

yeah, probably doable

@maelle
Copy link
Member Author

maelle commented Nov 16, 2020

I think I could even try and make a PR

@maelle maelle changed the title provide a custom testthat skippers? provide a custom testthat skipper? Nov 17, 2020
@maelle maelle mentioned this issue Nov 17, 2020
Merged
@sckott sckott added this to the v0.6 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

provide a custom testthat skipper ropensci/vcr
2 participants
@sckott @maelle