Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a custom testthat skipper #195

Merged
merged 10 commits into from
Nov 20, 2020
Merged

provide a custom testthat skipper #195

merged 10 commits into from
Nov 20, 2020

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 17, 2020

Fix #191

@maelle maelle requested a review from sckott November 17, 2020 08:44
R/skip-vcr-off.R Outdated Show resolved Hide resolved
R/skip-vcr-off.R Show resolved Hide resolved
R/skip-vcr-off.R Show resolved Hide resolved
R/skip-vcr-off.R Outdated Show resolved Hide resolved
R/skip-vcr-off.R Outdated Show resolved Hide resolved
tests/testthat/test-skip-vcr-off.R Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #195 (408d015) into master (521a124) will increase coverage by 0.66%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   79.75%   80.42%   +0.66%     
==========================================
  Files          39       40       +1     
  Lines        1576     1645      +69     
==========================================
+ Hits         1257     1323      +66     
- Misses        319      322       +3     
Impacted Files Coverage Δ
R/skip-vcr-off.R 50.00% <50.00%> (ø)
R/use_cassette.R 100.00% <0.00%> (ø)
R/configuration.R 72.47% <0.00%> (+8.13%) ⬆️
R/serializers.R 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521a124...8fe93bb. Read the comment docs.

@maelle maelle requested a review from sckott November 19, 2020 09:12
@maelle
Copy link
Member Author

maelle commented Nov 20, 2020

Any further comment?

@sckott sckott added this to the v0.6 milestone Nov 20, 2020
@sckott
Copy link
Collaborator

sckott commented Nov 20, 2020

looks good

@sckott sckott added the tooling label Nov 20, 2020
@sckott sckott merged commit 6987d9b into master Nov 20, 2020
@sckott sckott deleted the skip branch November 20, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a custom testthat skipper?
3 participants