Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcr_configure: new param to quiet all messages #226

Closed
sckott opened this issue Mar 2, 2021 · 3 comments
Closed

vcr_configure: new param to quiet all messages #226

sckott opened this issue Mar 2, 2021 · 3 comments
Milestone
v1.0

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 2, 2021 •
edited
Loading

e.g., vcr_configure(..., quiet = TRUE)

would quiet

  • CrulAdapter enabled/HttrAdapter enabled, in webmockr
  • CrulAdapter disabled/HttrAdapter disabled, in webmockr
  • ejecting casssette, in vcr
@sckott sckott added this to the v0.7.0 milestone Mar 2, 2021
@sckott sckott mentioned this issue Mar 3, 2021
Closed
@sckott sckott closed this as completed in 6551b21 Mar 3, 2021
sckott added a commit that referenced this issue Mar 5, 2021
@sckott
#226 remove quiet param from use_cassette/insert_cassette usage
9791833 
can only set quiet param now from vcr_configure()
bump dev version
@maelle maelle mentioned this issue Mar 8, 2021
Closed
2 tasks
@dpprdan
Copy link
Member

dpprdan commented Mar 8, 2021

@sckott since testthat 3e does not suppress messages anymore, would it be a good idea to automatically set quiet = TRUE (or otherwise suppress vcr messages) if run with testthat 3e? Maybe testthat sets an appropriate envvar?

@sckott
Copy link
Collaborator Author

sckott commented Mar 8, 2021

@dpprdan probably we can set to true - having a look

sckott added a commit that referenced this issue Mar 8, 2021
@sckott
#226 change quiet default to TRUE - fix tests - add more suppression …
6671b4e 
…points in code, bump ver
@sckott
Copy link
Collaborator Author

sckott commented Mar 8, 2021

@dpprdan okay, reinstall and try again, default=TRUE now

@sckott sckott mentioned this issue Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@sckott @dpprdan