-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN message about broken reverse dependency checks #235
Comments
|
Thanks. Was going to send an email to people this morning. I did run revdep checks and didn't get any issues (and I don't personally use the function in my own http pkgs), but I should have emailed about this issue, sorry about that. Looking into it |
👋🏻 My PR #230 probably caused this. Sorry for the trouble this is causing! I can reproduce with https://github.com/ropensci/opencage/tree/devel.
( I looking into ways how to catch this. Maybe |
- DESCRIPTION is not available for tests run by R CMD check, ropensci#235
Using However, since |
(p.s. @dpprdan ultimately responsibility is with me as the lead maintainer, so no worries) |
Thanks! Still sucks though to have this go to CRAN and causing revdeps to fail. Apparently I didn't run R CMD check on opencage since #230 got merged (or I didn't install that change locally?) or else I would have caught it. Strange. |
Works with that fork! |
- DESCRIPTION is not available for tests run by R CMD check, #235
All tests pass locally for me (running
devtools::test
) but fail running as part ofdevtools::check
. The error I get is the same as CRAN:I was able to pass check associated tests by removing the call to
vcr_test_path
in the autogenerated "setup" file and hardcoding the path to the fixtures directory.The text was updated successfully, but these errors were encountered: