Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Specify runner/container images and codecov for joint_limits #1504

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

Necessary changes to make ros-controls/ros2_control_ci#53 work for noble.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (16fbde3) to head (41cd687).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1504       +/-   ##
===========================================
+ Coverage   62.67%   88.66%   +25.98%     
===========================================
  Files          96      101        +5     
  Lines       11311     8238     -3073     
  Branches     8151      722     -7429     
===========================================
+ Hits         7089     7304      +215     
+ Misses        715      673       -42     
+ Partials     3507      261     -3246     
Flag Coverage Δ
unittests 88.66% <ø> (+25.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine and the CI seems to be happy, as well (I assume the RHEL fail to be independent)

@christophfroehlich
Copy link
Contributor Author

I assume the RHEL fail to be independent

yes, and nothing new :( #1367

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit db00041 into master Apr 29, 2024
11 of 12 checks passed
@christophfroehlich christophfroehlich deleted the ci_noble branch April 29, 2024 19:08
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
)

* Specify runner/container images

* Add joint_limits to coverage

* Satisfy flake8 on noble

(cherry picked from commit db00041)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/load_controller.py
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
)

* Specify runner/container images

* Add joint_limits to coverage

* Satisfy flake8 on noble

(cherry picked from commit db00041)
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
)

* Specify runner/container images

* Add joint_limits to coverage

* Satisfy flake8 on noble
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
) (#1520)

* Specify runner/container images

* Add joint_limits to coverage

* Satisfy flake8 on noble

(cherry picked from commit db00041)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
) (#1519)

* Specify runner/container images

* Add joint_limits to coverage

* Satisfy flake8 on noble

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants