Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the controller type as parameter in ctrl namespace #502

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

christophfroehlich
Copy link
Contributor

This changes the location of declaring the controller type, which will be possible with ros-controls/ros2_control#1502

I tried to write it consistently:

  • Controller types without parameters are declared in the controller_manager namespace (joint_state_broadcaster)
  • Others are declared in the controllers' namespaces, which is considered to be best-practice from now on.

@saikishor
Copy link
Member

@christophfroehlich Thanks a lot for helping :)

@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Jul 24, 2024

Needs ros-controls/ros2_control#1640 to work with example_15

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@christophfroehlich christophfroehlich merged commit 902b4bd into master Jul 30, 2024
11 of 13 checks passed
@christophfroehlich christophfroehlich deleted the controller_type branch July 30, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants