-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give the controller type as parameter in ctrl namespace #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@christophfroehlich Thanks a lot for helping :) |
christophfroehlich
force-pushed
the
controller_type
branch
from
July 24, 2024 10:44
9ab845c
to
24558c8
Compare
Needs ros-controls/ros2_control#1640 to work with example_15 |
christophfroehlich
force-pushed
the
controller_type
branch
from
July 29, 2024 08:15
807e94b
to
1ac5e13
Compare
This was referenced Jul 29, 2024
Merged
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
erickisos,
mcbed,
progtologist and
VanshGehlot
July 29, 2024 19:59
This was referenced Jul 30, 2024
saikishor
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
This was referenced Jul 31, 2024
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the location of declaring the controller type, which will be possible with ros-controls/ros2_control#1502
I tried to write it consistently: