-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add jazzy and other minor updates #1114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophfroehlich
commented
Apr 29, 2024
•
edited
Loading
edited
- Add Jazzy workflows (I decided to create dedicated files, because it easier to maintain if we branch for jazzy)
- Add filters to run the ROS - workflows only if code has changed, and the doc workflow only if docs have changed. (branches+path filter have to match both to run the workflow)
- Check Docs - workflow now uses the correct branch of control.ros.org (not every page is available on every distro any more).
- Run pre-commit auto-update only once per month
christophfroehlich
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Apr 29, 2024
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
fmauch,
jaron-l,
livanov93 and
VX792
April 29, 2024 20:10
fmauch
suggested changes
May 7, 2024
Also, I was wondering, why the check_docs workflows didn't have any path restrictions, now I am wondering even more while reviewing ros-controls/ros2_control#1521 |
Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
fmauch
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the work @christophfroehlich
The failing CI seems unrelated.
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Add file type filters * Add jazzy workflows and readme * Check docs on correct branch * Specify workflow names * Run auto-update only once per month * Update upstream pre-commit wf --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 4ae8daf) # Conflicts: # .github/workflows/iron-abi-compatibility.yml # .github/workflows/rolling-check-docs.yml
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Add file type filters * Add jazzy workflows and readme * Check docs on correct branch * Specify workflow names * Run auto-update only once per month * Update upstream pre-commit wf --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 4ae8daf) # Conflicts: # .github/workflows/humble-abi-compatibility.yml
christophfroehlich
added a commit
that referenced
this pull request
May 8, 2024
* Add file type filters * Add jazzy workflows and readme * Check docs on correct branch * Specify workflow names * Run auto-update only once per month * Update upstream pre-commit wf --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 4ae8daf) # Conflicts: # .github/workflows/humble-abi-compatibility.yml Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
added a commit
that referenced
this pull request
May 8, 2024
* Add file type filters * Add jazzy workflows and readme * Check docs on correct branch * Specify workflow names * Run auto-update only once per month * Update upstream pre-commit wf --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 4ae8daf) # Conflicts: # .github/workflows/iron-abi-compatibility.yml # .github/workflows/rolling-check-docs.yml Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.