Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix steering controllers library code documentation and naming #1149

Merged
merged 14 commits into from
Jun 5, 2024
Merged

Fix steering controllers library code documentation and naming #1149

merged 14 commits into from
Jun 5, 2024

Commits on May 27, 2024

  1. Update documentation and consolidate variable names

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    78d6004 View commit details
    Browse the repository at this point in the history

  2. Simplify private methods and further update docs

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    759264b View commit details
    Browse the repository at this point in the history

  3. Rename methods

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f85fc5b View commit details
    Browse the repository at this point in the history

  4. Rename method and variables

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8602f49 View commit details
    Browse the repository at this point in the history

  5. Rename convert method

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    bf9998b View commit details
    Browse the repository at this point in the history

  6. Rename variables and improve doc

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2531973 View commit details
    Browse the repository at this point in the history

  7. Rename local variables

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    77212df View commit details
    Browse the repository at this point in the history

  8. Use std::isfinite instead of !isnan 

    Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
    @christophfroehlich @saikishor
    christophfroehlich and saikishor committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e115836 View commit details
    Browse the repository at this point in the history

  9. Use a lowercase theta for heading 

    Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
    @christophfroehlich @saikishor
    christophfroehlich and saikishor committed May 27, 2024
    Configuration menu
    Copy the full SHA
    6942c1a View commit details
    Browse the repository at this point in the history

  10. Make some temporary variables const

    @christophfroehlich
    christophfroehlich committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4e5653d View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Let update_from_position call update_from_velocity

    @christophfroehlich
    christophfroehlich committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f0b2780 View commit details
    Browse the repository at this point in the history

  2. Explicitly set variables with 0 in constructor

    @christophfroehlich
    christophfroehlich committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d8ce400 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Fix docstring

    @christophfroehlich
    christophfroehlich committed May 29, 2024
    Configuration menu
    Copy the full SHA
    479d850 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Apply consistent variable naming 

    Co-authored-by:  Quique Llorente <ellorent@redhat.com>
    @christophfroehlich @qinqon
    christophfroehlich and qinqon committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    089a803 View commit details
    Browse the repository at this point in the history