Humble Mecanum Drive Controller #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
general changes not any fundamental changes Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
using std instead of boost Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
re-positioned controller_state_publisher_->unlock(); Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
github-actions
bot
requested review from
arne48,
bmagyar,
christophfroehlich,
destogl,
fmauch,
jaron-l and
VX792
|
@luis-camero, all pull requests must be targeted towards the |
|
@luis-camero thanks for updating this for humble. But first, let us merge #512 into master. Could you leave a review comment there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-ported #512 to Humble.
Moved implementation of the
update_reference_from_subcribersmethod toupdate_and_write_commandsto maintain timing check functionality from Jazzy.