-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix admittance controller interface read/write logic #1232
Merged
bmagyar
merged 2 commits into
ros-controls:master
from
StoglRobotics-forks:fix-admittance-interface-r/w
Jul 31, 2024
Merged
Fix admittance controller interface read/write logic #1232
bmagyar
merged 2 commits into
ros-controls:master
from
StoglRobotics-forks:fix-admittance-interface-r/w
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
fmauch,
livanov93 and
saikishor
July 31, 2024 10:57
bmagyar
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense sir :D
destogl
approved these changes
Jul 31, 2024
bmagyar
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Jul 31, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 33e35f0)
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 33e35f0)
This was referenced Jul 31, 2024
saikishor
approved these changes
Jul 31, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 1, 2024
bmagyar
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ROS
rolling
and gazeboHarmonic
, I've found two bugs while trying to control a robot using bothvelocity
andposition
control.write_state_to_hardware()
,state_commanded.positions
are mistakenly being written to bothvelocity
andacceleration
command interfaces.write_state_to_hardware()
andread_state_from_hardware()
, checking whether the controller haspos
/vel
/acc
interfaces is done usingif-else
clauses. This causes the block to exit upon first true condition, meaning, after confirmingposition
interface exists,velocity
andacceleration
interfaces never get written to or read fromThese fixes are verified in my use case, but seem obvious enough that no tests need to be written to verify these claims.
Nonetheless, let me know if you'd like some tests before merging.
Cheers!