Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test if python files were changed #1264

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Also test if python files were changed #1264

merged 1 commit into from
Aug 22, 2024

Conversation

christophfroehlich
Copy link
Contributor

I realized that the CI jobs are not running in #1259

Not that we would have any tests for rqt_jtc, but just in case we get some.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (4ab22a5) to head (c051b69).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   80.43%   80.45%   +0.01%     
==========================================
  Files         105      105              
  Lines        9353     9351       -2     
  Branches      818      816       -2     
==========================================
  Hits         7523     7523              
  Misses       1556     1556              
+ Partials      274      272       -2     
Flag Coverage Δ
unittests 80.45% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wunderbar!

@bmagyar bmagyar merged commit cdfc0af into master Aug 22, 2024
18 checks passed
@bmagyar bmagyar deleted the ci/add_glob_py branch August 22, 2024 14:07
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
RobertWilbrandt pushed a commit to RobertWilbrandt/ros2_controllers that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants