Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steering-odometry): convert twist to steering angle (backport #1288) #1295

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 25, 2024

The logic in this function was incorrect, if we divide by 0., the input of the atan goes to inf which should result in PI/2 instead of 0.. What should be handled instead are nan values as an input of the atan function that can happen if we input 0./0..


This is an automatic backport of pull request #1288 done by Mergify.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (448cf43) to head (90dba26).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1295      +/-   ##
==========================================
- Coverage   87.20%   87.20%   -0.01%     
==========================================
  Files         103      103              
  Lines       11438    11437       -1     
  Branches     7252     7253       +1     
==========================================
- Hits         9975     9974       -1     
- Misses       1457     1463       +6     
+ Partials        6        0       -6     
Flag Coverage Δ
unittests 87.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 82.16% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 02215d1 into humble Sep 26, 2024
11 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1288 branch September 26, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants