-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile robot kinematics 101 and improve steering library docs #954
Add mobile robot kinematics 101 and improve steering library docs #954
Conversation
👀 @aleksandrsizmailovs @roncapat @franzrammerstorfer @petkovich @ARK3r |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
===========================================
- Coverage 71.86% 47.43% -24.43%
===========================================
Files 41 41
Lines 3650 3862 +212
Branches 1794 1816 +22
===========================================
- Hits 2623 1832 -791
- Misses 707 769 +62
- Partials 320 1261 +941
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thanks! I was not sure where to start and where to end. I think about it.
We should at least assume, that ever actuated joint has a feedback sensor (e.g., no combination of traction joints on the rear axle but speed sensors on the front axle) -> this would get very complicated to parameterize for every combination. But as far as I understood: the claim of this lib at the current state was bicycle, tricycle, ackermann; all with front or back steering; and with the traction axle being the other than the steering axle? (the steering+traction ackermann description is not part of this then, but part of this proposal of a "general" library #692 (comment)) |
Am I right that for a trailing steering axis ( |
@petkovich this may be interesting to you |
This pull request is in conflict. Could you fix it @christophfroehlich? |
Very nice @christophfroehlich this looks like a very good documentation page! Nice work! |
Thanks! Would you mind adding a review in the UI? (Below "Files Changed" tab -> Review Changes). Yes, this will be published on control.ros.org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM!
ab0af1f
to
bffa4f9
Compare
bffa4f9
to
c27108d
Compare
(cherry picked from commit d076ea2)
(cherry picked from commit d076ea2) # Conflicts: # steering_controllers_library/doc/userdoc.rst # tricycle_controller/doc/userdoc.rst
…) (#1160) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v1...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is the first step of #931, but I focused only on steering on the front axle for now.
Edit: I also added the diff-drive kinematics to have a complete documentation.
After peer-reviewing of the equations I'd start to rename the variables of the library to match the doc and fix possible bugs.
rendered docs (updated 5d6aee7)