Add serial communication for ESP controllers #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's possible to define ESP_SERIAL, due to this definition an ESP controller can linked by serial. - define ESP_SERIAL: use the esp in "serial mode" - not define ESP_SERIAL: use the esp in "tcp mode"
|
This looks ok for me. |
|
Looks reasonable. |
|
Hello, I find myself in the same situation, where I'd like to use an ESP through serial, with ROS Noetic. Would it make sense to do the same changes on the noetic branch? Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
reason:
Due to the clock frequency, I decided to use an ESP, but for personal reason I prefer to use it by USB serial.
May be, this option can help someone.
use:
test: