Add !relative_url YAML constructor #1057
Merged
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this constructor is to support relative URL resolution in arbitrary locations in the buildfarm's configuration YAML. Some fields in the config already implicitly do this (such as the buildfile references from the index), but this will add support for any field to contain a relative URL.
nuclearsandwich
approved these changes
Jun 27, 2024
|
Yeah, we should probably document this as well as I don't currently have a plan to transition the existing implicit URL resolutions to use this, but we could consider a follow-up change to deprecate them at some point. |
|
I added docs in the most recent changes. PTAL. |
nuclearsandwich
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this constructor is to support relative URL resolution in arbitrary locations in the buildfarm's configuration YAML. Some fields in the config already implicitly do this (such as the buildfile references from the index), but this will add support for any field to contain a relative URL.
Staging deployment: https://build.test.ros2.org/job/ci__infra_ubuntu_noble_amd64/
Example use: https://github.com/ros2/ros_buildfarm_config/blob/200fcfd96aceaf2d0791682a6b16e80a59669e52/global/ci-infra.yaml#L43-L44