evaluate conditions in devel jobs #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2019
nuclearsandwich
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Answering my own question: No build_type handling needs to be included for devel jobs as build types are handled by the build tool not the job generation.
Since we now have several tools all making essentially identical use of the evaluated conditions, I wonder if it's worth pushing an API for getting only truthy dependencies back up to catkin_pkg. We shouldn't wait for that to make use of this though. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate the conditions in devel jobs to address #620.
Before:
After: