Add "openeuler" support to os_detect.py #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2023
cottsay
reviewed
Feb 12, 2024
| return os.path.exists(self._release_file) | ||
| def get_version(self): | ||
| if self.is_os(): | ||
| return self._release_info["VERSION_ID"] |
There was a problem hiding this comment.
Would you mind updating this to prevent the KeyError from raising if the release file doesn't contain VERSION_ID?
I don't have any strong feelings about how to handle the lack of VERSION_ID, but a KeyError isn't very actionable. I think either returning an empty string or raising OsNotDetected would probably be appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also
ros-infrastructure/rosdep#919
ros/rosdistro#36933