Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To use fisheye undistotion #299

Closed

Conversation

zgxsin
Copy link

@zgxsin zgxsin commented Oct 11, 2019

Update the code to work with distortion model EQUIDISTANT

@zgxsin
Copy link
Author

zgxsin commented Nov 11, 2019

@vrabaud Could you review this MR? EQUIDISTANT distortion model is defined in image_geometry package, but not implemented. I think this is a bug. I have already used this MR for Equidistant model. It works well.

@YoshuaNava
Copy link

YoshuaNava commented Jan 9, 2020

Dear @vrabaud and @mjcarroll,
My colleague @zgxsin has implemented the equidistant distortion model. We have internally tested this and found that it leads to lower reprojection error (measured with Kindr) when matching corner features collected from rectified images.

We would be really interested in doing anything needed to contribute this to your repo and have it on master soon. We don't want to diverge from the main development branch and miss the chance to contribute our changes to the robotics community.

Please let us know your thoughts.

Best regards,
Yoshua Nava

@mintar
Copy link
Contributor

mintar commented Mar 3, 2021

This PR can be closed, since #358 was finally merged.

@YoshuaNava
Copy link

@mintar Thank you for taking forward #358 and pushing for it to be merged, it is a really nice contribution. 🙏

@zgxsin
Copy link
Author

zgxsin commented Mar 5, 2021

This PR can be closed, since #358 was finally merged.

Thanks. Close it now.

@zgxsin zgxsin closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants