-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-rosdep-install & rosdep-check options #830
Add skip-rosdep-install & rosdep-check options #830
Conversation
Could you just sign-off your commit? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #830 +/- ##
==========================================
- Coverage 47.53% 45.81% -1.72%
==========================================
Files 2 2
Lines 284 299 +15
Branches 77 80 +3
==========================================
+ Hits 135 137 +2
- Misses 149 162 +13 ☔ View full report in Codecov by Sentry. |
3f3e05c
to
fdba6e2
Compare
78742ea
to
b4e1880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry for the long delay!
I have a suggestion and some requests:
- Can you add a new section in the README to document the
skip-rosdep-install
androsdep-check
options? Like the sections here: https://github.com/ros-tooling/action-ros-ci#Usage. You could add a single section for both options, since they're tightly connected. It would be good to explicitly mention why users might want to use these options, e.g., to fail if dependencies are not properly declared. - If possible, a simple test that uses these 2 options (and doesn't fail) would be good.
Also, please rebase on master
.
@kaichie may I help advance this PR somehow? I'm not good in writing tests in this context, but I may help with the docs for example. |
Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: nelson <kaichie.lee@gmail.com>
b4e1880
to
18b9415
Compare
@christophebedard Added the suggestions and requested changes, let me know if I missed anything. Thanks for checking! @roncapat Appreciate your offer to assist! I have updated the test and the docs. However, feel free to make any adjustment to the docs if you think it's appropriate. 😃 |
@christophebedard friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions! Then this should be ready.
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: nelson <kaichie.lee@gmail.com>
2a8623c
to
63520d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I released this as |
Closes #829
This PR adds an optional argument for skipping
rosdep install
in the action (skip-rosdep-install
) and an optional argument to runrosdep check
(rosdep-check
), which only works ifskip-rosdep-install
is also enabled.