Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Noble for Rolling. #193

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Switch to Noble for Rolling. #193

merged 5 commits into from
Apr 29, 2024

Conversation

clalancette
Copy link
Contributor

No description provided.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from a team as a code owner April 29, 2024 16:14
@clalancette clalancette requested review from emersonknapp and MichaelOrlov and removed request for a team April 29, 2024 16:14
@christophebedard
Copy link
Member

christophebedard commented Apr 29, 2024

  /usr/bin/bash -c source /opt/ros/rolling/setup.sh && colcon coveragepy-result --packages-select libstatistics_collector --verbose --coverage-report-args -m
  /usr/local/lib/python3.12/dist-packages/colcon_core/argument_parser/type_collector.py:9: UserWarning: 'colcon_core.argument_parser.type_collector.TypeCollectorDecorator' has been deprecated
    class TypeCollectorDecorator(ArgumentParserDecorator):
  /usr/local/lib/python3.12/dist-packages/colcon_core/argument_parser/type_collector.py:62: UserWarning: 'colcon_core.argument_parser.type_collector.SuppressTypeConversions' has been deprecated, use 'colcon_core.argument_parser.action_collector.SuppressTypeConversions' instead
    class SuppressTypeConversions:
  usage: colcon [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL]
                {build,coveragepy-result,extension-points,extensions,graph,info,lcov-result,list,metadata,mixin,test,test-result,version-check}
                ...
  colcon: error: unrecognized arguments: -m

This was just fixed and I just created a new release, so I'll try to re-trigger the job.


Warning: Unexpected input(s) 'colcon-mixin-name'

This needs to be replaced by colcon-defaults (ros-tooling/action-ros-ci#591), e.g.: https://github.com/ros2/ros2_tracing/blob/c0e59c442e61f6c638f06a48a00ecf10913442fb/.github/workflows/test.yml#L76

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Whooppee! It works, finally. @christophebedard I could use review when you have a minute.

@clalancette
Copy link
Contributor Author

Thanks, appreciated! With that, I'm going to merge this in since it only touched the github jobs and not the code at all.

@clalancette clalancette merged commit 6797100 into rolling Apr 29, 2024
12 checks passed
@clalancette clalancette deleted the clalancette/fix-ci branch April 29, 2024 19:47
wep21 pushed a commit to wep21/libstatistics_collector that referenced this pull request May 18, 2024
* Switch to Noble for Rolling.

* Updates for the latest action-ros-ci.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants