-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add void annotation #194
Conversation
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rolling #194 +/- ##
==========================================
Coverage ? 24.35%
==========================================
Files ? 67
Lines ? 5382
Branches ? 662
==========================================
Hits ? 1311
Misses ? 3976
Partials ? 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me with green CI.
CI looks good here, so going ahead and merging. Thanks for the PR. |
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
This PR surpresses compiler warning in a package which uses rclcpp_compoent.