Removed tango-icon-theme dependency #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@ros-pull-request-builder retest this please |
|
To summarize the main assumption: the Tango is never being used on Linux. The new PR will come up with a better approach to provide the Tango icons for platforms like macOS and Windows. |
|
@ahcorde Please address the CI failure. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this PR ros-visualization/tango_icons_vendor#4 (review) we are going to remove the
tango-icon-themedependency and replace it with the tango_icons_vendor package.The logic and the new dependency will be updated in this other PR #222
Signed-off-by: ahcorde ahcorde@gmail.com