-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(qt_gui) setFallbackThemeName(original_theme) #279
(qt_gui) setFallbackThemeName(original_theme) #279
Conversation
@cottsay @clalancette could you take a look at this as you worked on #250 |
Would it be possible for a system to be configured to use Tango by default and another theme as a fallback already? Wouldn't this regress the behavior in that scenario? |
The changes you made in #250 always overrule the default theme, if I understand the code correctly. So in case Tango was the default theme, you end up with Tango being the default and the backup. I don't know a system/Qt can/will have a fallback theme by default. original_theme='Vimix'
QIcon.themeSearchPaths()=['/opt/ros/humble/share/tango_icons_vendor/resource/icons', '/home/USERNAME/.local/share/icons', '/usr/local/share/icons', '/usr/share/icons', '/var/lib/snapd/desktop/icons', ':/icons']
QIcon.fallbackThemeName()=''
QIcon.fallbackSearchPaths()=[] I changed the logic to prevent ending up with Tango as default and fallback theme. |
@cottsay could you have a look again after adding some changes based on your comment? |
@cottsay firendly ping ping ;) |
@clalancette could you do the 2nd review and merge? Please also merge the backports. P.S. Please create new releases for the various distros. |
@clalancette can you please do the 2nd review? Or can we merge it with only the approval of @cottsay? |
@clalancette Thanks! Do we want the backports to Humble and Iron too? See #280 and #281 |
@cottsay @clalancette Could you create a new rolling release including this PR? |
Old:
New:
Iron backport: #281
Humble backport: #280
Fixes: ros-visualization/rqt_image_view#79