Error when re-arranging widgets over plot. Kinetic, 16.04 #35

vmatos · 2016-09-20T10:39:35Z

When I try to re-arrange widgets in rqt, whenever I pass with it over a plot widget, I get the error:

Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/dock_widget.py", line 90, in _event
    new_parent = self._get_new_parent(widget)
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/dock_widget.py", line 139, in _get_new_parent
    widget = widget.parent()
TypeError: 'Canvas' object is not callable

The text was updated successfully, but these errors were encountered:

vmatos · 2016-09-20T10:48:59Z

If I don't got over the plot widget, and drop it in place, I get:

Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent
    self.figure.tight_layout()
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1756, in tight_layout
    self.subplots_adjust(**kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1612, in subplots_adjust
    self.subplotpars.update(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 230, in update
    raise ValueError('bottom cannot be >= top')
ValueError: bottom cannot be >= top

RYO0115 · 2016-11-24T07:56:07Z

I have the same problem running rqt_gui on Ubuntu 16.04.

Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/dock_widget.py", line 90, in _event
new_parent = self._get_new_parent(widget)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/dock_widget.py", line 139, in _get_new_parent
widget = widget.parent()
TypeError: 'Canvas' object is not callable

Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent
self.figure.tight_layout()
File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1756, in tight_layout
self.subplots_adjust(**kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1612, in subplots_adjust
self.subplotpars.update(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 230, in update
raise ValueError('bottom cannot be >= top')
ValueError: bottom cannot be >= top

I tried
sudo apt-get install ros-kinetic-rqt-gui
but, nothing changes.

dirk-thomas · 2016-12-20T22:09:07Z

@vmatos @RYO0115 Can you please try the proposed fix from ros-visualization/qt_gui_core#76 and confirm if it fixes the problem for you.

If there are problems remaining can you please describe the exact steps how to reproduce it.

vmatos · 2016-12-21T12:06:27Z

My procedure:

mkdir -p overlay_ws/src
cd overlay_ws/src
git clone https://github.com/ros-visualization/qt_gui_core.git -b fix_parent_logic
cd ..
catkin_make

Then I verified the error was reproducible:

run: rqt
Place 2 plot widgets.
Hold widget and try moving it over plot area.
Get error.

Then I tested the fix:

overlaying workspace: source devel/setup.bash
run: rqt
Place 2 plot widgets.
Hold widget and try moving it over plot area.
No error!

@dirk-thomas My test indicates this PR fixes my first issue: TypeError: 'Canvas' object is not callable

dirk-thomas · 2016-12-21T14:18:43Z

I was able to reproduce the first error easily. The PR fixes (also for you) which is good. But I never saw the second error. What are the steps to reproduce the second one?

vmatos · 2016-12-21T14:25:48Z

To reproduce the 2nd error:

run: rqt
Place 2 plot widgets. they should appear side by side.
Move one of the plot widgets over the other, so they are distributed vertically.
Get error

dirk-thomas · 2016-12-21T16:47:52Z

I can reproduce the second error with these steps. Unfortunately the error is within matplotlib and I am not sure if there is anything we can do in the rqt plugin itself. Btw it is also ticketed upstream: matplotlib/matplotlib#5456

Refer to https://github.com/ros-visualization/rqt/issues/110 Basically its getting bad resize events when two matplotlib canvas exist at the same time. So now every time a tab switch is changed it destroys one if it existed and creates a new one if needed.

EliteMasterEric · 2019-08-26T19:32:01Z

It appears this issue is still existing.

Since that report was submitted, matplotlib has gone through several major version changes, of which they claim changes should have been pushed.

However, creating two rqt_plot windows and attempting to align one on top of the other still results in the following stack trace on Kinetic and Melodic:

Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent
    self.figure.tight_layout()
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1756, in tight_layout
    self.subplots_adjust(**kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1612, in subplots_adjust
    self.subplotpars.update(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 230, in update
    raise ValueError('bottom cannot be >= top')
ValueError: bottom cannot be >= top

rqt still utilizes Python 2, and the newest version of matplotlib compatible is 3.0.3. Version 3.1.1 is also available for Python3.

The issue appears to still exist upstream, at least in Python2.

EliteMasterEric · 2019-08-26T20:12:28Z

It appears that my issue was the use of an old version of matplotlib, 1.5.1.

Completing the reproduction steps now produces the following stack trace:

Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent
    self.figure.tight_layout()
  File "/usr/local/lib/python2.7/dist-packages/matplotlib/figure.py", line 2307, in tight_layout
    pad=pad, h_pad=h_pad, w_pad=w_pad, rect=rect)
  File "/usr/local/lib/python2.7/dist-packages/matplotlib/tight_layout.py", line 349, in get_tight_layout_figure
    pad=pad, h_pad=h_pad, w_pad=w_pad)
  File "/usr/local/lib/python2.7/dist-packages/matplotlib/tight_layout.py", line 117, in auto_adjust_subplotpars
    fig.transFigure.inverted())
  File "/usr/local/lib/python2.7/dist-packages/matplotlib/transforms.py", line 1901, in inverted
    self._inverted = Affine2D(inv(mtx), shorthand_name=shorthand_name)
  File "/usr/lib/python2.7/dist-packages/numpy/linalg/linalg.py", line 526, in inv
    ainv = _umath_linalg.inv(a, signature=signature, extobj=extobj)
  File "/usr/lib/python2.7/dist-packages/numpy/linalg/linalg.py", line 90, in _raise_linalgerror_singular
    raise LinAlgError("Singular matrix")
numpy.linalg.linalg.LinAlgError: Singular matrix

Reproduction steps:

Open an RQT window.
Create two plots in that window.
Attempt to stack one plot vertically below the other, as pictured below.
RQT will crash with the above stack trace.

dirk-thomas · 2019-08-26T20:52:19Z

rqt still utilizes Python 2, and the newest version of matplotlib compatible is 3.0.3. Version 3.1.1 is also available for Python3.

The issue appears to still exist upstream, at least in Python2.

If the problem has been resolved upstream in a Python 3-only release the easiest is probably to wait for ROS Noetic (May 2020) which will target Python 3.

If the problem is still present in the latest code (which is Python 3) it is probably best to report this problem upstream.

EliteMasterEric · 2019-08-27T15:38:27Z

@dirk-thomas, please see my newest comment.

The issue does not appear if you are using the latest Python2 version of matplotlib (2.2.4). Instead, a second issue, a LinAlgError, occurs.

dirk-thomas · 2019-08-27T15:47:16Z

I read that comment. My feedback still applies to that different error message since I don't see what could be done in this repository.

d4n1elchen · 2020-02-16T08:45:35Z

So is there any workthrough for this issue for now?

EliteMasterEric · 2020-02-18T13:41:16Z

I believe the consensus was that we won't get an upstream fix for this and we will have to wait until Ros switches to Python 3 (I hate that Python 2 is still widely used, it's been a decade already!).

…

On Sun, Feb 16, 2020, 03:45 DanielChen ***@***.***> wrote: So is there any workthrough for this issue for now? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35?email_source=notifications&email_token=ABDLVRTF2PKL2Y6AAXAXWMLRDD4LBA5CNFSM4IPC6SZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4A64Y#issuecomment-586682227>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDLVRWQXWSZHOAHWYNNLEDRDD4LBANCNFSM4IPC6SZA> .

bergercookie · 2020-04-02T15:30:48Z

Hi there,

I came across this error myself and I did a bit of digging.
It's not an issue with rqt_plot as such, but rather with the version of matplotlib installed.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/matplotlib/backends/backend_qt5agg.py", line 77, in paintEvent
    self.resizeEvent(event)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 110, in resizeEvent
    self.figure.tight_layout()
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 2031, in tight_layout
    self.subplots_adjust(**kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1881, in subplots_adjust
    self.subplotpars.update(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 241, in update
    raise ValueError('bottom cannot be >= top')
ValueError: bottom cannot be >= top
[rqt-2] process has died [pid 14148, exit code -6, cmd /opt/ros/melodic/lib/rqt_gui/rqt_gui --perspective-file=/opt/ros/melodic/share/viz/rqt/a.perspective __name:=rqt __log:=/home/berger/.ros/log/faf34a34-74f0-11ea-89cc-0242ac190002/rqt-2.log].
log file: /home/berger/.ros/log/faf34a34-74f0-11ea-89cc-0242ac190002/rqt-2*.log

More specifically, i've encountered this issue with a particular rqt perspective configuration and matplotlib version 2.1.1. However after upgrading to matplotlib 2.2.5 I can confirm that the error goes away and instead I get a rather harmless warning:

/usr/local/lib/python2.7/dist-packages/matplotlib/tight_layout.py:182: UserWarning: The bottom and top margins cannot be made large enough to accommodate all axes decorations.
  warnings.warn('The bottom and top margins cannot be made large '

A quickfix to this issue would be something like the following on the rqt_plot side:

https://github.com/ros-visualization/rqt_plot/blob/master/src/rqt_plot/data_plot/mat_data_plot.py#L110

try:
    self.figure.tight_layout()
except ValueError:
    pass

dirk-thomas · 2020-04-03T16:18:33Z

A quickfix to this issue would be something like the following on the rqt_plot side:

@bergercookie Please consider to create a pull request for the proposed workaround.

Matplotlib emits errors like the following under specific canvas layouts: ```console Traceback (most recent call last): File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent self.figure.tight_layout() File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1756, in tight_layout self.subplots_adjust(**kwargs) File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1612, in subplots_adjust self.subplotpars.update(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 230, in update raise ValueError('bottom cannot be >= top') ValueError: bottom cannot be >= top ``` Current patch catches and suppresses that exception. References: - matplotlib/matplotlib#10915 - ros-visualization#35

* Fix #35 - "bottom cannot be >= top" matplotlib error Matplotlib emits errors like the following under specific canvas layouts: ```console Traceback (most recent call last): File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_plot/data_plot/mat_data_plot.py", line 107, in resizeEvent self.figure.tight_layout() File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1756, in tight_layout self.subplots_adjust(**kwargs) File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 1612, in subplots_adjust self.subplotpars.update(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/matplotlib/figure.py", line 230, in update raise ValueError('bottom cannot be >= top') ValueError: bottom cannot be >= top ``` Current patch catches and suppresses that exception. References: - matplotlib/matplotlib#10915 - #35 * renamed to `safe_tight_layout`, inverted logic to avoid duplicating the call Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

arjunskumar · 2020-04-25T16:31:06Z

2.2.5

@bergercookie Yes, it was because of matplotlib version issues, I resolved by upgrading to 2.2.5. Thanks

lucbettaieb · 2020-06-08T17:59:34Z

To bump this further, I encountered this issue and fixed by upgrading matplotlib.

sudo pip install --upgrade matplotlib

…ib error (ros-visualization#52)" This reverts commit cb7d874.

That's a cleaner way to resolve ros-visualization#35 and ros-visualization#54.

dirk-thomas transferred this issue from ros-visualization/rqt Aug 23, 2019

dirk-thomas mentioned this issue Aug 23, 2019

"ValueError: bottom cannot be >= top" when attempting to achieve a vertical configuration #34

Closed

dirk-thomas mentioned this issue Mar 26, 2020

Matplotlib #50

Closed

bergercookie mentioned this issue Apr 3, 2020

Fix #35 - "bottom cannot be >= top" matplotlib error #52

Merged

dirk-thomas closed this as completed in cb7d874 Apr 3, 2020

floesche mentioned this issue May 3, 2020

rqt_plot crashes when resizing the window #54

Closed

rhaschke added a commit to rhaschke/rqt_plot that referenced this issue Feb 4, 2021

Revert "Fix ros-visualization#35 - "bottom cannot be >= top" matplotl…

cff49ed

…ib error (ros-visualization#52)" This reverts commit cb7d874.

rhaschke added a commit to rhaschke/rqt_plot that referenced this issue Feb 4, 2021

Set minimum size of MatDataPlot's Canvas

9482157

That's a cleaner way to resolve ros-visualization#35 and ros-visualization#54.

rhaschke mentioned this issue Feb 4, 2021

fix resize bug #69

Merged

rhaschke added a commit to rhaschke/rqt_plot that referenced this issue Feb 5, 2021

Set minimum size of MatDataPlot's Canvas

de4129b

That's a cleaner way to resolve ros-visualization#35 and ros-visualization#54.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error when re-arranging widgets over plot. Kinetic, 16.04 #35

Error when re-arranging widgets over plot. Kinetic, 16.04 #35

vmatos commented Sep 20, 2016

vmatos commented Sep 20, 2016

RYO0115 commented Nov 24, 2016

dirk-thomas commented Dec 20, 2016

vmatos commented Dec 21, 2016 •

edited

Loading

dirk-thomas commented Dec 21, 2016

vmatos commented Dec 21, 2016

dirk-thomas commented Dec 21, 2016

EliteMasterEric commented Aug 26, 2019

EliteMasterEric commented Aug 26, 2019

dirk-thomas commented Aug 26, 2019

EliteMasterEric commented Aug 27, 2019

dirk-thomas commented Aug 27, 2019

d4n1elchen commented Feb 16, 2020

EliteMasterEric commented Feb 18, 2020 via email

bergercookie commented Apr 2, 2020 •

edited

Loading

dirk-thomas commented Apr 3, 2020

arjunskumar commented Apr 25, 2020

lucbettaieb commented Jun 8, 2020

Error when re-arranging widgets over plot. Kinetic, 16.04 #35

Error when re-arranging widgets over plot. Kinetic, 16.04 #35

Comments

vmatos commented Sep 20, 2016

vmatos commented Sep 20, 2016

RYO0115 commented Nov 24, 2016

dirk-thomas commented Dec 20, 2016

vmatos commented Dec 21, 2016 • edited Loading

dirk-thomas commented Dec 21, 2016

vmatos commented Dec 21, 2016

dirk-thomas commented Dec 21, 2016

EliteMasterEric commented Aug 26, 2019

EliteMasterEric commented Aug 26, 2019

dirk-thomas commented Aug 26, 2019

EliteMasterEric commented Aug 27, 2019

dirk-thomas commented Aug 27, 2019

d4n1elchen commented Feb 16, 2020

EliteMasterEric commented Feb 18, 2020 via email

bergercookie commented Apr 2, 2020 • edited Loading

dirk-thomas commented Apr 3, 2020

arjunskumar commented Apr 25, 2020

lucbettaieb commented Jun 8, 2020

vmatos commented Dec 21, 2016 •

edited

Loading

bergercookie commented Apr 2, 2020 •

edited

Loading