-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plots of array items #71
Conversation
…osidl methods instead of random adhoc utilities Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This probably should target a new @mabelzhang @cottsay what do you think? |
Actually |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
I think |
New branch sounds fine to me, whichever distro you guys figure out is the right one. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Oh thanks! I don't know what I checked before 😅 . |
This is targeting now a new I will open a PRs to |
Similar to ros-visualization/rqt_msg#11 (comment), we should also update the release and rosdistro repos as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this!
ros2/ros2#1097, ros2/ros2#1098, ros/rosdistro#28490, ros/rosdistro#28491 should solve everything |
Fixes #64.
I rewrote it completely to avoid
rqt_py_common.message_helpers/rqt_py_common.topic_helpers
.Those modules should never have existed really, they provide badly maintained implementations of utilities that already exist in
rosidl_runtime_py
orrosidl_parser
.