Fix plotting of values containers in an array #44
Conversation
src/rqt_plot/plot_widget.py
Outdated
| if is_array: | ||
| sequence_inner_type_regexp = re.match('sequence<(.*)>', slot_type) | ||
| if sequence_inner_type_regexp: | ||
| slot_type = sequence_innter_type_regexp.groupdict()['slot_type'] |
There was a problem hiding this comment.
This looks like a spelling mistake. Please update and afterwards test your patch locally.
Before this commit, attempting to plot a value in an array would
trigger the following exception:
Traceback (most recent call last):
File "/opt/ros/eloquent/lib/python3.6/site-packages/rqt_plot/plot_widget.py", line 259, in on_topic_edit_textChanged
plottable, message = is_plottable(self._node, topic_name)
File "/opt/ros/eloquent/lib/python3.6/site-packages/rqt_plot/plot_widget.py", line 154, in is_plottable
fields, message = get_plot_fields(node, topic_name)
File "/opt/ros/eloquent/lib/python3.6/site-packages/rqt_plot/plot_widget.py", line 137, in get_plot_fields
for slot, slot_type in field_class.get_fields_and_field_types().items():
AttributeError: 'NoneType' object has no attribute 'get_fields_and_field_types'
Line 129 in plot_widget.py:
field_class = message_helpers.get_message_class(slot_type)
...would be executed with slot_type set to 'sequence<foo_msgs/Foo>' which
returns a None value. field_class is set to None and the call to
get_fields_and_field_types is then failing.
This pull request adds an extra layer of logic before calling get_message_class
to ensure that, if the type is an array, we extract the inner array type
instead of attempting to run get_message_class on the DDS sequence type
directly.
Signed-off-by: Thomas Moulard <tmoulard@amazon.com>
thomas-moulard
force-pushed
the
tmoulard/fix-array
branch
from
3272c04 to
b30fd0d
Compare
|
What is the timeline of this issue? Will the eloquent or foxy debian package be patched with this fix? I'd like to plot sensor_msgs/JointState position[i] etc in ROS2. |
|
@dirk-thomas Is this ready to be merged? It looks like @thomas-moulard made the necessary fix in his most recent commit. I just tested the commit on my machine and I seem to have the same issue when trying to listen to |
|
@Michael-Equi I am not maintaining this repository anymore. Maybe the current maintainer can step up? |
|
Closing in favor of #71. |
Before this commit, attempting to plot a value in an array would trigger the following exception:
Line 129 in
plot_widget.py:...would be executed with slot_type set to
sequence<foo_msgs/Foo>whichreturns a
Nonevalue. field_class is set toNoneand the call toget_fields_and_field_typesis then failing.This pull request adds an extra layer of logic before calling get_message_class
to ensure that, if the type is an array, we extract the inner array type
instead of attempting to run get_message_class on the DDS sequence type
directly.