Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between clean_rosdep_yaml.py and validation scripts #41119

Open
amalnanavati opened this issue May 9, 2024 · 0 comments
Open

Comments

@amalnanavati
Copy link
Contributor

As discovered in #41118 , there is an inconsistency between the changes that script/clean_rosdep_yaml.py does and what is expected by the CI. Specifically, that script tries to remove single quotes around gentoo entries in the rosdep, whereas single quotes are required.

Perhaps script/clean_rosdep_yaml.py should be updated to enforce that gentoo entries have single quotes in them? That will restore the script as a useful tool for rosdep contributors. (As it stands, the script is not as useful as it could be, because running it makes hundreds of lines of changes.)

Potentially related to #41060 and #41059 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant