Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a subset of python builtin functions are permitted in xacro
${}
expressions for security reasons, for reasons listed here. I recently wanted to usemin
andmax
in a xacro file, so I wonder if they can be added to this list.I looked at the list of python builtin functions that could be useful for math operations, and many of them have alternatives since we import
math.*
:abs
: usemath.fabs
len
: use.__len__()
object methodpow
: use**
sum
: usemath.fsum
The only other one I would consider adding is
round
. You can get partial functionality withmath.floor
andmath.ceil
, but not the same. Currently, though, I just needmax
andmin
. I would propose back porting this to kinetic if it is acceptable.cc @sloretz @clalancette