Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rcljava_common cpp headers to have .hpp suffix #93

Merged
merged 10 commits into from
Mar 18, 2020
Merged

Rename rcljava_common cpp headers to have .hpp suffix #93

merged 10 commits into from
Mar 18, 2020

Commits on Feb 11, 2020

  1. Fix service and action interface generation 

    Before, we were not generating code for the messages and services that make up service and action
interfaces.

Due to issues with duplicate definitions caused by instantiating the msg.cpp.em template
multiple times, I've opted to generate separate files for each service, action, and the interfaces
that they are made of. This is similar to what we are doing with the generated Java code.

I've added a test confirming that generated service code can be used. Adding a test for actions is
difficult at the moment due to a circular dependency with action_msgs.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    8f8a75b View commit details
    Browse the repository at this point in the history

  2. Add missing header include 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6196b04 View commit details
    Browse the repository at this point in the history

  3. Rename top level generated cpp file 

    This avoids name clashing with other generated files. Similar to what we do with generated Java files.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    00260bf View commit details
    Browse the repository at this point in the history

  4. Fix JNI name mangling function so it works for service and action sub… 

    …types

For example, 'example_interfaces/srv/AddTwoInts_Request' should be mangled to 'example_1interfaces_srv_AddTwoInts_1Request'.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    efaf468 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Remove vestigal references to jni_package_name 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    29d1eac View commit details
    Browse the repository at this point in the history

  2. Add comment about action and service headers 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    97d0ead View commit details
    Browse the repository at this point in the history

  3. Simplify include logic 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    dc5d64d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Rename cpp headers to have .hpp suffix 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    589d1f9 View commit details
    Browse the repository at this point in the history

  2. Update files to reflect new header suffix 

    This resolves a cppcheck linter error complaining about "is invalid C code".
Changing the suffix causes cppcheck to treat the files as C++ code.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e795cdd View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'dashing' into jacob/fix_cppcheck_error

    @esteve
    esteve authored Mar 18, 2020
    Configuration menu
    Copy the full SHA
    0e442f0 View commit details
    Browse the repository at this point in the history