-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use imperative mood in docstrings. #362
Conversation
Where class names alone were not grammatical I elaborated with superclass names to get a valid imperative sentence. Fixes D401 in pydocstyle and flake8. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
038dbe9
to
ca50916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than comment
launch/.eggs/README.txt
Outdated
|
||
This directory caches those eggs to prevent repeated downloads. | ||
|
||
However, it is safe to delete this directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I'll cut that out.
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
dead59b
to
3603245
Compare
Where class names alone were not grammatical I elaborated with
superclass names to get a valid imperative sentence.
Fixes D401 in pydocstyle and flake8.
Contributes to closing ros2/build_farmer#255
Signed-off-by: Steven! Ragnarök steven@nuclearsandwich.com