Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the timeouts in wait_for_topic_launch_test. #360

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Increase the timeouts in wait_for_topic_launch_test. #360

merged 1 commit into from
Mar 30, 2023

Conversation

clalancette
Copy link
Contributor

Especially on a busy machine (and Windows), waiting only 2 seconds for 5 nodes and publishers to join a network and do discovery is too short. Increase this to 10 seconds, which should improve the reliability of this test.

This should help with #304, though I'm not sure if it will completely solve it. @Crola1702 FYI.

@clalancette
Increase the timeouts in wait_for_topic_launch_test.
13e571e 
Especially on a busy machine (and Windows), waiting
only 2 seconds for 5 nodes and publishers to join a
network and do discovery is too short.  Increase this to
10 seconds, which should improve the reliability of
this test.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 0c081a7 into rolling Mar 30, 2023
@clalancette clalancette deleted the clalancette/increase-testing-timeout branch March 30, 2023 17:29
@clalancette clalancette mentioned this pull request Apr 3, 2023
Open
clalancette added a commit that referenced this pull request Aug 24, 2023
@clalancette
Increase the timeout in wait_for_topic_launch_test.
26fab73 
In commit 0c081a7
(#360) we increased
the timeout to 10 seconds to accomodate slower discovery.
However, this was partially reverted in
2d125a5
(#353).

Restore the 10 second timeout to avoid flakes on the
buildfarm.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette mentioned this pull request Aug 24, 2023
Merged
clalancette added a commit that referenced this pull request Aug 28, 2023
@clalancette
Increase the timeout in wait_for_topic_launch_test. (#377)
a26e13a 
In commit 0c081a7
(#360) we increased
the timeout to 10 seconds to accomodate slower discovery.
However, this was partially reverted in
2d125a5
(#353).

Restore the 10 second timeout to avoid flakes on the
buildfarm.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @adityapande-1995