Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export modern CMake interface target #14

Merged
merged 2 commits into from
May 1, 2020

Conversation

dirk-thomas
Copy link
Member

Related to ros2/ros2#915.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas self-assigned this May 1, 2020
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some questions, otherwise LGTM!

Can this be contributed upstream?

orocos_kdl/src/CMakeLists.txt Outdated Show resolved Hide resolved
orocos_kdl/src/CMakeLists.txt Show resolved Hide resolved
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit 75a39f3 into ros2 May 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/export-interface-target branch May 1, 2020 17:20
jacobperron pushed a commit to jacobperron/orocos_kinematics_dynamics that referenced this pull request Oct 22, 2021
* export modern CMake interface target
* remove redundant include_directories

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

Original pull request on ROS 2 fork: ros2#14

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants