🧑‍🌾 cpplint include_order test regressions in all ros2 distributions

[Crola1702]

Description

cppplint shows multiple failures due to include_order in various files from performance_test repo.

Reference builds:

• RollingPerformance#57
• JazzyPerformance#19
• IronPerformance#109
• HumblePerformance#245

Most of the test regressions are related to cpplint include_order

Test regressions:

• projectroot.cpplint
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/resource_manager.hpp:48)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/resource_manager.hpp:49)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/resource_manager.hpp:50)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_callback_communicator.hpp:20)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_callback_communicator.hpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_communicator.hpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_communicator.hpp:22)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_waitset_communicator.hpp:20)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_waitset_communicator.hpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_waitset_communicator.hpp:22)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/communication_abstractions/ros2_waitset_communicator.hpp:23)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/data_running/data_runner_base.hpp:19)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/data_running/data_runner_factory.cpp:19)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/data_running/data_runner_factory.cpp:20)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.cpp:18)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.cpp:20)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.cpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.cpp:22)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.cpp:23)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.hpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.hpp:22)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.hpp:23)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/experiment_configuration.hpp:24)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/external_info_storage.hpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_configuration/external_info_storage.hpp:22)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:15)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:16)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:17)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:18)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:19)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:20)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:21)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:29)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/experiment_execution/analyze_runner.cpp:30)
• performance_test.cpplint.build/include_order [4] (/tmp/ws2/src/performance_test/performance_test/src/utilities/cpu_usage_tracker.hpp:19)

Affected files:

• resource_manager.hpp:48
• resource_manager.hpp:49
• resource_manager.hpp:50
• ros2_callback_communicator.hpp:20
• ros2_callback_communicator.hpp:21
• ros2_communicator.hpp:21
• ros2_communicator.hpp:22
• ros2_waitset_communicator.hpp:20
• ros2_waitset_communicator.hpp:21
• ros2_waitset_communicator.hpp:22
• ros2_waitset_communicator.hpp:23
• data_runner_base.hpp:19
• data_runner_factory.cpp:19
• data_runner_factory.cpp:20
• experiment_configuration.cpp:18
• experiment_configuration.cpp:20
• experiment_configuration.cpp:21
• experiment_configuration.cpp:22
• experiment_configuration.cpp:23
• experiment_configuration.hpp:21
• experiment_configuration.hpp:22
• experiment_configuration.hpp:23
• experiment_configuration.hpp:24
• external_info_storage.hpp:21
• external_info_storage.hpp:22
• analyze_runner.cpp:15
• analyze_runner.cpp:16
• analyze_runner.cpp:17
• analyze_runner.cpp:18
• analyze_runner.cpp:19
• analyze_runner.cpp:20
• analyze_runner.cpp:21
• analyze_runner.cpp:29
• analyze_runner.cpp:30
• cpu_usage_tracker.hpp:19

[Blast545]

I fixed this on main with: #53

Please do not close the issue until this is backported to the other distros.

[Blast545]

This was fixed after #55 and #56, @Crola1702 I don't have admin powers here, feel free to close this one.