Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ros-tooling versions #407

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Sep 24, 2024

See issue #406

Maybe a solution is to update the ros-tooling versions.

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat self-assigned this Sep 24, 2024
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Sep 24, 2024

Remark: ament_uncrustify seems to be different for ...

  • ROS build pipeline (successful)
    • Jpr__rclc__ubuntu_noble_amd64
    • Rpr__rclc__ubuntu_noble_amd64
  • Github build pipeline (fails)
    • CI RCLC Rolling / build (ubuntu-22.04, rolling) (pull_request)

regards only two source files:

  • test_action_client.cpp
  • test-action_server.cpp

If no changes are made regarding ament_uncrustify then ROS pipeline fails (regarding ament_uncrustify) and Github Pipeline is successful.

@JanStaschulat JanStaschulat merged commit b4e3b9c into rolling Sep 24, 2024
4 of 5 checks passed
@JanStaschulat JanStaschulat deleted the feature/update-ros-tooling-versions branch September 24, 2024 13:24
@christophebedard
Copy link
Member

christophebedard commented Sep 27, 2024

If no changes are made regarding ament_uncrustify then ROS pipeline fails (regarding ament_uncrustify) and Github Pipeline is successful.

It might be because GitHub CI here is using Ubuntu 22.04, while ROS CI is using Ubuntu 24.04. So they probably have different versions of uncrustify. Since Rolling and Jazzy use Ubuntu 24.04 now, you should change the CI config to use Ubuntu 24.04 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants