Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash Executor when send_response fails due to client failure. #2276

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Do not crash Executor when send_response fails due to client failure. #2276

merged 3 commits into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. Do not crash Executor when send_response fails due to client failure. 

    Related to ros2/ros2#1253

It is not sane that a faulty client can crash our service Executor, as
discussed in the referred issue, if the client is not setup properly,
send_response may return RCL_RET_TIMEOUT, we should not throw an error
in this case.

Signed-off-by: Zang MingJie <zealot0630@gmail.com>
    @kghost @fujitatomoya
    kghost authored and fujitatomoya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a5de541 View commit details
    Browse the repository at this point in the history

  2. Update rclcpp/include/rclcpp/service.hpp 

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Zang MingJie <zealot0630@gmail.com>
    @kghost @fujitatomoya
    kghost and fujitatomoya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d796a93 View commit details
    Browse the repository at this point in the history

  3. address review comments. 

    Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    60fb512 View commit details
    Browse the repository at this point in the history