Replace RuntimeError with new custom exception RCLError #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
force-pushed
the
customexception
branch
from
52e95e9
to
9c686f9
Compare
|
@suab321321 Thanks for the patch! It looks like there was some git branching issues, so I've updated your branch Also, for the future, it's good to populate the description and title with useful information (for example, a reference to the ticket this is fixing). I have updated the description for you this time. |
jacobperron
changed the title
|
@jacobperron thank you sir.. I will keep this in mind..will this be merged now sir? |
jacobperron
reviewed
Dec 6, 2019
jacobperron
reviewed
Dec 6, 2019
|
@jacobperron sir I m just comitting the suggested changes from here. |
allenh1
reviewed
Dec 9, 2019
allenh1
reviewed
Dec 9, 2019
jacobperron
reviewed
Dec 9, 2019
There was a problem hiding this comment.
Couple more things. And after addressing @allenh1's comments, I'll trigger CI.
|
@jacobperron done sir..... |
allenh1
reviewed
Dec 9, 2019
Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Hunter L. Allen <hunterlallen@protonmail.com>
Co-Authored-By: Hunter L. Allen <hunterlallen@protonmail.com>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
customexception
branch
from
d3428a4
to
261a2dc
Compare
jacobperron
approved these changes
Dec 10, 2019
|
@suab321321 Thanks again for the improvement! |
|
@allenh1 @jacobperron thank you for your guiding me sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
Replacing
RuntimeErrorwith new custom exceptionRCLError.