Allows propagations of cmd args to rclcpp::init #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
gonzodepedro
added
in progress
|
How about command line arguments for ROS 1 now? |
|
Command line arguments processing in ROS2 doesn't interfere, it process the ones that understands and doesn't modify the argc and argv. ROS1 command line arguments processing OTH removes arguments from the argv. That's why passing them first to ROS2 and later to ROS1 doesn't affect neither of them, while passing first to ROS1 and then to ROS2 ends up in the arguments for ROS2 being ignored. |
dirk-thomas
approved these changes
Mar 22, 2019
This was referenced Mar 22, 2019
Merged
|
|
Linux-aarch64 and Windows CI jobs test failed on test already known to fail, not related to this PR |
gonzodepedro
removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar
This changes the order of initialization of nodes. By initializing firs the ROS2 node it allows cmd args to be passed to it.