New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported the gdb backtrace from NAV2 #4190

Merged

clalancette merged 62 commits into ros2:rolling from GauravKumar9920:rolling

Apr 21, 2024

Contributor

GauravKumar9920 commented Feb 27, 2024 •

edited

Loading

I have ported the gdb backtrace documentation form the NAV2 to ROS2 documentation. more changes need to be done to this.

this pull request is linked to ISSUE #4178

GauravKumar9920 requested review from clalancette and audrow as code owners

February 27, 2024 11:57

clalancette requested changes

View reviewed changes

Contributor

clalancette left a comment

Besides what I've left inline, we recently introduced a much shorter version of this in #4175 . We should probably move that advice from there into this document, so it is all in one place.

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

Contributor Author

GauravKumar9920 commented Feb 27, 2024 •

edited

Loading

Besides what I've left inline, we recently introduced a much shorter version of this in #4175 . We should probably move that advice from there into this document, so it is all in one place.

Thanks @clalancette for the giving this a review :)
I will look onto all the inlines and resolve them. This was an initial commit, in the commits following this one I would resolve most of the issues and implement the improvements suggested by the community.

fujitatomoya requested changes

View reviewed changes

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

Contributor Author

GauravKumar9920 commented Mar 6, 2024

hii @clalancette @fujitatomoya I have made some changes based on you previous review.
Kindly let me know of any Improvement or changes that needs to be done.

GauravKumar9920 requested review from fujitatomoya and clalancette

March 6, 2024 16:15

fujitatomoya approved these changes

View reviewed changes

Collaborator

fujitatomoya left a comment

thanks for your contribution. a few more comments.

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

Ryanf55 reviewed

View reviewed changes

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

clalancette requested changes

View reviewed changes

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

GauravKumar9920 requested review from clalancette, fujitatomoya and Ryanf55

March 9, 2024 09:16

clalancette requested changes

View reviewed changes

source/Tutorials/Intermediate.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

fujitatomoya reviewed

View reviewed changes

Collaborator

fujitatomoya left a comment

i think this is getting closer, i am good to go if @clalancette 's comments are resolved. especially for replacing this into How-To-Guide section.

GauravKumar9920 requested a review from clalancette

March 16, 2024 07:02

fujitatomoya reviewed

View reviewed changes

source/Tutorials/Intermediate/Get-Backtrace-in-ROS2.rst Outdated Show resolved Hide resolved

GauravKumar9920 requested a review from fujitatomoya

March 17, 2024 13:16

Contributor Author

GauravKumar9920 commented Mar 20, 2024

hi @fujitatomoya @clalancette @Ryanf55 are there any updates regarding the documentation.

Ryanf55 suggested changes

View reviewed changes

Contributor

Ryanf55 left a comment

Looking very good, just a few touchups from my end.

That said, you moved the content I wrote on debugging tests, but didn't delete the old stuff. It's now duplicated in two places.

Instead, can you delete the old debugging tests contents, keep the header, and then just add in a link to this page with a brief explanation saying to review the GDB guide if you need to debug tests.

source/How-To-Guides/Get-Backtrace-in-ROS-2.rst Outdated Show resolved Hide resolved

source/How-To-Guides/Get-Backtrace-in-ROS-2.rst Outdated Show resolved Hide resolved

fujitatomoya approved these changes

View reviewed changes

Collaborator

fujitatomoya left a comment

@GauravKumar9920 thanks for the contribution and effort! lgtm.

@clalancette can you take a look at the changes?

GauravKumar9920 requested review from Ryanf55 and fujitatomoya

March 30, 2024 19:57

Contributor Author

GauravKumar9920 commented Mar 30, 2024

Apologies for the delay, I had my university exams, I have deleted the old stuff and added the link to new tutorial.

Ryanf55 approved these changes

View reviewed changes

Contributor Author

GauravKumar9920 commented Mar 31, 2024 •

edited

Loading

@clalancette @audrow @fujitatomoya Is it good to be merged can you also give it review.

fujitatomoya requested changes

View reviewed changes

source/Tutorials/Intermediate/Testing/CLI.rst Outdated Show resolved Hide resolved

GauravKumar9920 requested review from fujitatomoya and Ryanf55

April 4, 2024 10:50

GauravKumar9920 and others added 20 commits

April 21, 2024 09:12


          updated the tutorial to how-to-guide

0bc91b5


          updated the node usage

8b49a40


          oved the documentation to How-to guides

fa29ae9


          fixed multiple topic issue

5fea31c


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

d767efa

Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

dc751c8

Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          deleted the old stuff and added a link to the new page

2f1a07b


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

ca204db

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

ed8e2c5

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

769a544

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides.rst

cc7fa54

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

17da276

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

dc16ebb

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

4af8446

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

ec8250a

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/How-To-Guides/Get-Backtrace-in-ROS-2.rst

00f3ad4

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Update source/Tutorials/Intermediate/Testing/CLI.rst

13886e8

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>


          Chenged the file name and corrected whitespaces.

b562f45

Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>


          Chenged the file name

9f646cd

Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>


          Move location of the guide.

dd0832d

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

clalancette force-pushed the rolling branch from abcef9f to dd0832d Compare

April 21, 2024 13:20

clalancette approved these changes

View reviewed changes

Contributor

clalancette left a comment

This looks great now. Thanks for all the work here @GauravKumar9920

clalancette merged commit cc7701d into ros2:rolling

4 checks passed

mergify bot pushed a commit that referenced this pull request


          Ported the gdb backtrace from NAV2 (#4190)

0ff2b32

* Ported the gdb backtrace in the

* Added a new section- Reading the Stack Trace

* Added new sections explaining what is backtrace and how it can be useful. I have also included a simple examples of pancakes stacking.

Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>
Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc7701d)

mergify bot mentioned this pull request

Ported the gdb backtrace from NAV2 (backport #4190) #4307

Merged

mergify bot pushed a commit that referenced this pull request


          Ported the gdb backtrace from NAV2 (#4190)

da9524e

* Ported the gdb backtrace in the

* Added a new section- Reading the Stack Trace

* Added new sections explaining what is backtrace and how it can be useful. I have also included a simple examples of pancakes stacking.

Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>
Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc7701d)

mergify bot mentioned this pull request

Ported the gdb backtrace from NAV2 (backport #4190) #4308

Merged

clalancette mentioned this pull request

Port GDB Guide from NAV2 to ros2_documenation #4178

Closed

clalancette pushed a commit that referenced this pull request


          Ported the gdb backtrace from NAV2 (#4190) (#4307)

* Ported the gdb backtrace in the

* Added a new section- Reading the Stack Trace

* Added new sections explaining what is backtrace and how it can be useful. I have also included a simple examples of pancakes stacking.

Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>
Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc7701d)

Co-authored-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>

clalancette pushed a commit that referenced this pull request


          Ported the gdb backtrace from NAV2 (#4190) (#4308)

d087216

* Ported the gdb backtrace in the

* Added a new section- Reading the Stack Trace

* Added new sections explaining what is backtrace and how it can be useful. I have also included a simple examples of pancakes stacking.

Signed-off-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>
Signed-off-by: GauravKumar9920 <gaurav.og.9920@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Ryan <ryanfriedman5410+github@gmail.com>
(cherry picked from commit cc7701d)

Co-authored-by: Gaurav Kumar <84905312+GauravKumar9920@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels