Launch large project tutorial fix #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I think I know what went wrong. It's now written in the way that the TF2 tutorials should have gone first. But, the static broadcaster for the carrot1 is missing from the launch file.... I'm now going through the TF2 tutorials to see if I can find an good equivalent to put in the launch file. |
|
My bad, I accidently removed the broadcaster from carrot1 for the tutorial. Than the PR is done as is and ready for review. |
clalancette
requested changes
Jul 26, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io>
|
No problem! I've committed your suggestion so all good to merge :) |
|
@clalancette Friendly ping for one more round of review. |
clalancette
approved these changes
Aug 21, 2024
clalancette
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc)
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc)
This was referenced Aug 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc) # Conflicts: # source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
clalancette
pushed a commit
that referenced
this pull request
Aug 21, 2024
* remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc) Co-authored-by: Kimberly N. McGuire <kimberly@bitcraze.io>
clalancette
pushed a commit
that referenced
this pull request
Aug 21, 2024
* remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc) Co-authored-by: Kimberly N. McGuire <kimberly@bitcraze.io>
clalancette
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Launch large project tutorial fix (#4454) * remove instruction that will fail, inconsistency * add rviz folder in setup.py * add warning for missing environment variable * Update source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst Signed-off-by: Kimberly McGuire <kimberly@bitcraze.io> Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 2a9b2fc)
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partly this issue from the jazzy tutorial testing: osrf/ros2_test_cases#1151
I can't really figure out why the carrot1 frame is not showing up other than that it is forgotten in the launch file? I still get this error:
I could consider fixing this by adding the carrot1 somewhere... or removing all notion of carrot1 all together? I've started a proposal in this ticket to reshape the launch tutorials anyway... #4453.
Anyway, this should at least target Rolling and Jazzy documents.